[Qemu-devel] Re: [PATCH] add VMSTATE_BOOL

[Gerd Hoffmann]

  Hi,

> > > > +static int get_bool(QEMUFile *f, void *pv, size_t size)
> > > > +{
> > > > +    bool *v = pv;
> > > > +    *v = qemu_get_byte(f);
> > > > +    return 0;

> I think we should verify that value is 0 or 1 and fail
> migration otherwise, to make it more robust.

I still think such a check doesn't belong into the migration code as 
such a bug would exist without migration too.  And if anything we should 
check on save not on load, otherwise qemu can write out savevm images 
which it will refuse to load.  I wouldn't call this "robust".

cheers,
  Gerd