[Qemu-devel] Re: [PATCHv3 03/14] Keep track of ISA ports ISA device is using in qdev.

[Gerd Hoffmann]

  Hi,

>       register_ioport_write (s->port, 1, 1, gus_writeb, s);
>       register_ioport_write (s->port, 1, 2, gus_writew, s);
> +    isa_init_ioport_range(dev, s->port, 2);
>
>       register_ioport_read ((s->port + 0x100)&  0xf00, 1, 1, gus_readb, s);
>       register_ioport_read ((s->port + 0x100)&  0xf00, 1, 2, gus_readw, s);
> +    isa_init_ioport_range(dev, (s->port + 0x100)&  0xf00, 2);
>
>       register_ioport_write (s->port + 6, 10, 1, gus_writeb, s);
>       register_ioport_write (s->port + 6, 10, 2, gus_writew, s);
>       register_ioport_read (s->port + 6, 10, 1, gus_readb, s);
>       register_ioport_read (s->port + 6, 10, 2, gus_readw, s);
> +    isa_init_ioport_range(dev, s->port + 6, 10);
>
>
>       register_ioport_write (s->port + 0x100, 8, 1, gus_writeb, s);
>       register_ioport_write (s->port + 0x100, 8, 2, gus_writew, s);
>       register_ioport_read (s->port + 0x100, 8, 1, gus_readb, s);
>       register_ioport_read (s->port + 0x100, 8, 2, gus_readw, s);
> +    isa_init_ioport_range(dev, s->port + 0x100, 8);

Seeing all the duplication here and elsewhere ...

How about moving the register_ioport_{read,write} calls into 
isa_init_ioport_range() ?

cheers,
  Gerd