Re: [Qemu-devel] [PATCH 1/2] Delete useless 'extern' qualifiers for functions

[Stefan Weil]

Am 13.11.2010 13:49, schrieb Blue Swirl:
> 'extern' qualifier is useless for function declarations. Delete
> them.
>
> Signed-off-by: Blue Swirl <address@hidden>
> ---
> cache-utils.h | 2 +-
> cmd.h | 36 ++++++++--------
> darwin-user/commpage.c | 2 +-
> darwin-user/syscall.c | 24 +++++-----
> dis-asm.h | 85 +++++++++++++++++++--------------------
> envlist.h | 14 +++---
> exec-all.h | 2 +-
> fpu/softfloat-native.c | 4 +-
> fsdev/qemu-fsdev.h | 6 +-
> hw/file-op-9p.h | 2 +-
> hw/hw.h | 21 +++++-----
> hw/mips.h | 2 +-
> hw/s390-virtio-bus.h | 16 +++----
> hw/virtio-9p-xattr.h | 17 ++++----
> hw/virtio-9p.h | 4 +-
> hw/watchdog.h | 8 ++--
> linux-user/arm/nwfpe/fpa11.h | 6 +-
> linux-user/arm/nwfpe/fpopcode.h | 4 +-
> linux-user/syscall.c | 10 ++--
> m68k-dis.c | 11 ++---
> osdep.c | 2 +-
> qemu-common.h | 2 +-
> slirp/slirp.h | 10 ++--
> target-s390x/cpu.h | 6 +-
> tests/cris/sys.h | 4 +-
> tests/runcom.c | 4 +-
> ui/cocoa.m | 6 +-
> ui/d3des.h | 8 ++--
> ui/x_keymap.h | 4 +-
> 29 files changed, 158 insertions(+), 164 deletions(-)

extern qualifiers in *.c files are very useful:

They should be replaced by include statements
(this makes it possible to check whether declaration
and implementation match). Without 'extern', they are
difficult to detect, with 'extern' this is easy.

So either replace those extern declarations by an
include statement (best solution), or don't touch the
'extern' there, or add a comment which can be easily
found (XXX or TODO).

Regards
Stefan