qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH] linux-user: remove unnecessary local from __get


From: Riku Voipio
Subject: Re: [Qemu-devel] [PATCH] linux-user: remove unnecessary local from __get_user(), __put_user()
Date: Mon, 15 Nov 2010 10:00:44 +0200
User-agent: Mutt/1.5.18 (2008-05-17)

On Mon, Nov 08, 2010 at 06:13:58PM +0000, Peter Maydell wrote:
> Remove an unnecessary local variable from the __get_user() and
> __put_user() macros. This avoids confusing compilation failures
> if the name of the local variable ('size') happens to be the
> same as the variable the macro user is trying to read/write.

Looks fine, will push on my next patchset

Acked-by: Riku Voipio <address@hidden>
 
> Signed-off-by: Peter Maydell <address@hidden>
> ---
>  linux-user/qemu.h |    6 ++----
>  1 files changed, 2 insertions(+), 4 deletions(-)
> 
> diff --git a/linux-user/qemu.h b/linux-user/qemu.h
> index 708021e..d717392 100644
> --- a/linux-user/qemu.h
> +++ b/linux-user/qemu.h
> @@ -266,8 +266,7 @@ static inline int access_ok(int type, abi_ulong addr, 
> abi_ulong size)
>   */
>  #define __put_user(x, hptr)\
>  ({\
> -    int size = sizeof(*hptr);\
> -    switch(size) {\
> +    switch(sizeof(*hptr)) {\
>      case 1:\
>          *(uint8_t *)(hptr) = (uint8_t)(typeof(*hptr))(x);\
>          break;\
> @@ -288,8 +287,7 @@ static inline int access_ok(int type, abi_ulong addr, 
> abi_ulong size)
>  
>  #define __get_user(x, hptr) \
>  ({\
> -    int size = sizeof(*hptr);\
> -    switch(size) {\
> +    switch(sizeof(*hptr)) {\
>      case 1:\
>          x = (typeof(*hptr))*(uint8_t *)(hptr);\
>          break;\
> -- 
> 1.7.1
> 



reply via email to

[Prev in Thread] Current Thread [Next in Thread]