Re: [Qemu-devel] [PATCH v2 1/2] Minimal RAM API support

[Alexander Graf]

On 16.11.2010, at 15:55, Anthony Liguori wrote:

> On 11/01/2010 10:14 AM, Alex Williamson wrote:
>> This adds a minimum chunk of Anthony's RAM API support so that we
>> can identify actual VM RAM versus all the other things that make
>> use of qemu_ram_alloc.
>> 
>> Signed-off-by: Alex Williamson<address@hidden>
>> ---
> 

[...]

> 
>> +static QemuRamSlot *qemu_ram_find_slot(target_phys_addr_t start_addr,
>> +                                       ram_addr_t size)
>> +{
>> +    QemuRamSlot *slot;
>> +
>> +    QLIST_FOREACH(slot,&ram_slots.slots, next) {
>> +        if (slot->start_addr == start_addr&&  slot->size == size) {
>> +            return slot;
>> +        }
>> +
>> +        if (ranges_overlap(start_addr, size, slot->start_addr, slot->size)) 
>> {
>> +            abort();
>>   
> 
> Should display a message before aborting.

Why not use hw_error?


Alex