qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v2 1/2] Minimal RAM API support


From: Anthony Liguori
Subject: Re: [Qemu-devel] [PATCH v2 1/2] Minimal RAM API support
Date: Tue, 16 Nov 2010 09:08:05 -0600
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.15) Gecko/20101027 Lightning/1.0b1 Thunderbird/3.0.10

On 11/16/2010 09:02 AM, Alexander Graf wrote:
+static QemuRamSlot *qemu_ram_find_slot(target_phys_addr_t start_addr,
+                                       ram_addr_t size)
+{
+    QemuRamSlot *slot;
+
+    QLIST_FOREACH(slot,&ram_slots.slots, next) {
+        if (slot->start_addr == start_addr&&   slot->size == size) {
+            return slot;
+        }
+
+        if (ranges_overlap(start_addr, size, slot->start_addr, slot->size)) {
+            abort();

Should display a message before aborting.
Why not use hw_error?

Another good suggestion.

Regards,

Anthony Liguori

Alex--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to address@hidden
More majordomo info at  http://vger.kernel.org/majordomo-info.html




reply via email to

[Prev in Thread] Current Thread [Next in Thread]