qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v4 0/3]: QMP: Human Monitor passthrough


From: Luiz Capitulino
Subject: Re: [Qemu-devel] [PATCH v4 0/3]: QMP: Human Monitor passthrough
Date: Wed, 17 Nov 2010 10:39:10 -0200

On Wed, 17 Nov 2010 11:27:31 +0100
Markus Armbruster <address@hidden> wrote:

> Luiz Capitulino <address@hidden> writes:
> 
> > Simple example:
> >
> > -> { "execute": "human-monitor-command", "arguments": { "command-line": 
> > "print /i 10+25" } }
> > <- { "return": "35\r\n" }
> >
> > Please, check individual patches for details. Also note that this series
> > depends on the script improvements one.
> >
> > Also, Markus suggestion of having an assert() in qemu_chr_close() have not
> > been added this series because I don't know what to assert(). But that's an
> > incremental change anyway and should prevent this series from being merged.
> 
> We talked about it when we discussed v2.  While it shouldn't be hard,
> it's not required, and I don't want to delay this series any further.
> 
> Same for documenting or fixing qobject_to_json() for embedded '\0'.
> 
> ACK series

Thanks for reviewing it, Markus.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]