Re: [Qemu-devel] [PATCH 08/10] ahci: add ahci emulation

[Gerd Hoffmann]

  Hi,

> > Hmm, no bus registered anywhere.  Dunno whenever it makes sense to
> > register ide bus(es) here or whenever we should create a new sata
> > bus.
>
> I'm not sure I understand this comment :).

The ahci controller should register one or more busses where you can 
hook up devices to via -device.  Right now the code seems to use one ide 
bus per sata port, with ide drives being attached to the master channel 
only.  The ide bus isn't registered though, so it isn't visible via 
qdev.  Thus you can't construct a machine with ahci using -device.

Also a ide bus as it works currently isn't exactly a good fit, there is 
no such thing as master/slave in sata.  Dunno whenever it is better to 
create a new sata bus or to extend the current ide bus code so it can 
handle both pata and sata.

Hope it is more clear now ;)

cheers,
  Gerd