qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [RFC][PATCH v3 01/21] virtproxy: base data structures a


From: Anthony Liguori
Subject: Re: [Qemu-devel] [RFC][PATCH v3 01/21] virtproxy: base data structures and constants
Date: Thu, 18 Nov 2010 09:56:49 -0600
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.15) Gecko/20101027 Lightning/1.0b1 Thunderbird/3.0.10

On 11/18/2010 09:51 AM, Jes Sorensen wrote:
Yes, I think Jes was just looking for an excuse to say "typedefmeharder"
:-)
Actually typedefs are not listed as a must do thing in CODING_STYLE,
fortunately!

That's a bug in CODING_STYLE.

typedefing structures is one of the core characteristics of QEMU coding style.

Regards,

Anthony Liguori

  It's just a really bad habit that is applied all over the
place in QEMU :(

http://www.linuxjournal.com/article/5780?page=0,2
search for typedef, for a lot of good reasoning why we shouldn't do this.

Jes




reply via email to

[Prev in Thread] Current Thread [Next in Thread]