|
| From: | Gerd Hoffmann |
| Subject: | [Qemu-devel] Re: [PATCH 10/16] scsi: Use 'SCSIRequest' directly |
| Date: | Thu, 18 Nov 2010 17:16:55 +0100 |
| User-agent: | Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.9) Gecko/20100827 Red Hat/3.1.3-1.el6 Thunderbird/3.1.3 |
On 11/18/10 15:47, Hannes Reinecke wrote:
Rather than to access a SCSIRequest via an abstract 'tag' we can as well use it directly and save us the lookup.
Hmm. Looks like a few more request handling changes than a pure s/tag/req/ + zap lookups sneaked into that patch. There are new get_req and put_req callbacks for example. At minimum these changes must be documented in the commit message. Even better splitted into separate patches.
cheers, Gerd
| [Prev in Thread] | Current Thread | [Next in Thread] |