Re: [Qemu-devel] [RFC][PATCH v3 11/21] virtproxy: add handler for control packet

[Michael Roth]

On 11/18/2010 10:22 AM, Jes Sorensen wrote:
> On 11/18/10 17:18, Michael Roth wrote:
> > On 11/18/2010 05:35 AM, Jes Sorensen wrote:
> > > You should never have two closing braces in the same column like this -
> > > something is wrong with the formatting.
> >
> > That's from using a block for the case
> > switch () {
> > case: {
> >      ...
> > }
> > }
> >
> > Alternative is to indent the "case:", which is "right" I think, but
> > aligning those with switch() seems to be pretty standard to conserve space.
>
> Why do you need braces around the case: { } ? That is not normally used
> throughout the code.

I use them here to avoid declaring a bunch of variables may not be used 
depending on the case. Although, it might cleaner to use separate 
functions here instead.

> Cheers,
> Jes