qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 1/6] Make the necessary changes in Makefile and


From: Stefan Hajnoczi
Subject: Re: [Qemu-devel] [PATCH 1/6] Make the necessary changes in Makefile and configure file.
Date: Fri, 19 Nov 2010 09:55:54 +0000

The commit message "Make the necessary changes in Makefile and
configure file" provides no information, especially outside the
context of your patch series.  Please choose something more specific
about what the patch is doing.

CONFIG_POSIX=y excludes mingw32.  Does this commit break Windows
builds?  I suspect vnc_thread and io_thread may not be available on
Windows anyway.

Should we actually add qemu-thread.o where threadlets.o gets added
instead of putting it next to posix-aio-compat.o?

Stefan



reply via email to

[Prev in Thread] Current Thread [Next in Thread]