[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 16/16] megasas: LSI Megaraid SAS emulation
|
From: |
Jes Sorensen |
|
Subject: |
Re: [Qemu-devel] [PATCH 16/16] megasas: LSI Megaraid SAS emulation |
|
Date: |
Fri, 19 Nov 2010 15:31:28 +0100 |
|
User-agent: |
Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.12) Gecko/20101103 Fedora/1.0-0.33.b2pre.fc14 Lightning/1.0b3pre Thunderbird/3.1.6 |
On 11/19/10 15:06, Markus Armbruster wrote:
>> Only comment, as you are adding another SCSI driver, maybe it's time to
>> make the driver selection configurable, rather than hard coding the build?
>
> What do you mean by that?
>
> We hardcode lsi53c895a in two places where we really mean "default SCSI
> controller type": pc_pci_device_init(), which applies to "-drive
> if=scsi", and qemu_pci_hot_add_storage(), which applies to "pci_add
> storage if=scsi". Not sure making that default configurable is worth
> it.
>
> If you want more control than -drive and pci_add provice, use -device
> and device_add.
What I mean is for most other device types we allow to specify a list of
wanted devices at the configure line, which is what I am suggesting we
added support for for SCSI as well.
Cheers,
Jes