Re: [Qemu-devel] [PATCH 12/16] scsi-generic: use plain ioctl

[Hannes Reinecke]

On 11/20/2010 02:25 AM, adq wrote:
> On 20 November 2010 00:41, Nicholas A. Bellinger <address@hidden> wrote:
>> On Fri, 2010-11-19 at 19:39 +0100, Christoph Hellwig wrote:
>>> On Thu, Nov 18, 2010 at 03:47:36PM +0100, Hannes Reinecke wrote:
>>>>
>>>> aio_ioctl is emulated anyway and currently broken.
>>>
>>> What's broken about it currently?
>>
>> Mmmmmm, I do not recall this being broken in the first place..?  There
>> was a single issue with megasas+bdrv_aio_ioctl() with WinXP (that did
>> not appear with lsi53c895a) that was mentioned on the list earlier in
>> the year that required a patch to use bdev_ioctl(), but last I recall
>> Hannes had already fixed this in recent megasas.c code w/ 32-bit MSFT
>> guests.  Also, this is what I have been with scsi_generic.c and
>> scsi_bsg.c into TCM_loop in my v0.12.5 megasas tree, and I am not
>> observing any obvious issues with AIO IOCTLs for SG_IO/BSG into Linux
>> guests.
>>
>> I will give AIO IOCTL ops a run with these on v2.6.37-rc2 lock-less KVM
>> host mode <-> TCM_Loop to verify against the v0.12.5 megasas tree.
> 
> Could this AIO ioctl breakage perhaps be the one I fixed here?
> http://web.archiveorange.com/archive/v/1XS1vROmfC7dN9wYxsmt
> 
> The patch is defintely in the latest git... it works fine for me with
> my scsi-generic MMC command patches.

Ah. Yes, this looks like it. I'll give it a spin; I've made the
original patch against an older git rev so I might've missed that one.

Cheers,

Hannes
-- 
Dr. Hannes Reinecke                   zSeries & Storage
address@hidden                        +49 911 74053 688
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Markus Rex, HRB 16746 (AG Nürnberg)