[Qemu-devel] Re: [PATCH 1/1] iscsi: add iSCSI block device support

[Kevin Wolf]

Am 21.11.2010 23:17, schrieb ronnie sahlberg:
> List,
> 
> Please find attached a gzipped patch against master that adds support of 
> iSCSI.
> It is sent in gz format because of its uncompressed size, >100kb.

I think there's something missing in your mail. :-)

Anyway, I got the code from the KVM list, and I have some general comments:

* Please split this into some smaller patches and send them as a patch
  series. Inline the patches instead of a gzipped attachment, because
  that makes it a lot easier to comment the code when replying to your
  mail.
* Have a look at CODING_STYLE in the repository, especially at the
  sections about 80 chars per line and whitespace.
* Don't use printf() but error_report() for error messages
* Try to use qemu functions instead of POSIX ones so that the code
  will also work on Windows and other platforms. If you can't make it
  run on Windows, still use qemu functions where possible and change
  the Makefile to compile it only for POSIX hosts.
* Once you use qemu_malloc, you can drop your NULL checks. qemu_malloc
  never returns an error.
* Use QLISTs (qemu-queue.h) instead of introducing a new SLIST

Kevin