[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 11/16] scsi-disk: add data direction checking
|
From: |
Christoph Hellwig |
|
Subject: |
Re: [Qemu-devel] [PATCH 11/16] scsi-disk: add data direction checking |
|
Date: |
Mon, 22 Nov 2010 12:20:32 +0100 |
|
User-agent: |
Mutt/1.3.28i |
On Thu, Nov 18, 2010 at 03:47:32PM +0100, Hannes Reinecke wrote:
>
> scsi_req_parse() already provides for a data direction setting,
> so we should be using it to check for correct direction.
Instead of just a debug printf that almost no one compiles in shouldn't
we reject the incorrect commands?