[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 11/16] scsi-disk: add data direction checking
|
From: |
Hannes Reinecke |
|
Subject: |
Re: [Qemu-devel] [PATCH 11/16] scsi-disk: add data direction checking |
|
Date: |
Mon, 22 Nov 2010 12:28:51 +0100 |
|
User-agent: |
Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.15) Gecko/20101026 SUSE/3.0.10 Thunderbird/3.0.10 |
On 11/22/2010 12:20 PM, Christoph Hellwig wrote:
> On Thu, Nov 18, 2010 at 03:47:32PM +0100, Hannes Reinecke wrote:
>>
>> scsi_req_parse() already provides for a data direction setting,
>> so we should be using it to check for correct direction.
>
> Instead of just a debug printf that almost no one compiles in shouldn't
> we reject the incorrect commands?
>
Good point. Will be fixing it up for the next version.
Cheers,
Hannes
--
Dr. Hannes Reinecke zSeries & Storage
address@hidden +49 911 74053 688
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Markus Rex, HRB 16746 (AG Nürnberg)