Re: [Qemu-devel] [PATCH 10/12] config: Add header file for device config options

[Alexander Graf]

On 23.11.2010, at 20:21, Blue Swirl wrote:

> On Tue, Nov 23, 2010 at 2:34 PM, Alexander Graf <address@hidden> wrote:
>> So far we have C preprocessor defines for target and host config
>> options, but we're lacking any information on which devices are
>> available.
>> 
>> We do need that information at times though, for example in the
>> ahci patch where we need to call a legacy init function depending
>> on whether we have support compiled in or not.
>> 
>> So this patch makes all config-devices options available as header
>> file. Please only include it in machine description code!
> 
> How about including config-devices.h from hw/boards.h instead? On the
> downside, all targets will be recompiled when config-devices.h change,
> even if they don't have any device dependencies.

Not sure it makes sense to do this change this time around. If we can avoid 
dependency on device configuration, we should. So if we can limit the scope 
this is included in, it's good IMHO.

In fact, maybe the correct solution to the issue would be to move the legacy 
-drive instantiation to the -drive code, as it is already with virtio-blk. If 
used with -device and -drive ...,if=none the whole magic isn't necessary 
anyways.


Alex