[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] Re: [PATCH] scsi-generic: bugfixes for 'SCSIRequest' conver
From: |
Hannes Reinecke |
Subject: |
[Qemu-devel] Re: [PATCH] scsi-generic: bugfixes for 'SCSIRequest' conversion |
Date: |
Wed, 24 Nov 2010 11:46:42 +0100 |
User-agent: |
Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.15) Gecko/20101026 SUSE/3.0.10 Thunderbird/3.0.10 |
On 11/24/2010 11:34 AM, Kevin Wolf wrote:
> Am 24.11.2010 11:16, schrieb Hannes Reinecke:
>> The second one is actually a genuine error, and a rather old one to
>> boot. It went in with this commit:
>>
>> commit 89c0f6438d16ebceccdcd096bbc0b5536146a443
>> Author: aurel32 <address@hidden>
>> Date: Fri Oct 17 08:08:56 2008 +0000
>> Subject: scsi-generic: correct error management
>>
>> So I'd rather have it submitted separately.
>> And a second opinion is _definitely_ required here.
>> nab, can you do the honours?
>
> The commit message of this commit says it's a workaround for a problem
> with lsi:
>
>> - when a read is aborted due to a mark/EOF/EOD/EOM, the len reported to
>> controller can be 0. LSI controller emulation doesn't know how to manage
>> this. A workaround found is to call the completion routine with
>> SCSI_REASON_DONE just after calling it with SCSI_REASON_DATA with len=0.
>
> Are you sure that it's not needed any more?
>
Don't ask me. I didn't do the patch, and my knowledge of lsi HBA
internals is scanty.
Nic, can you comment here?
Cheers,
Hannes
--
Dr. Hannes Reinecke zSeries & Storage
address@hidden +49 911 74053 688
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Markus Rex, HRB 16746 (AG Nürnberg)
- [Qemu-devel] [PATCH] scsi-generic: bugfixes for 'SCSIRequest' conversion, Nicholas A. Bellinger, 2010/11/24
- [Qemu-devel] Re: [PATCH] scsi-generic: bugfixes for 'SCSIRequest' conversion, Hannes Reinecke, 2010/11/24
- [Qemu-devel] Re: [PATCH] scsi-generic: bugfixes for 'SCSIRequest' conversion, Nicholas A. Bellinger, 2010/11/24
- [Qemu-devel] Re: [PATCH] scsi-generic: bugfixes for 'SCSIRequest' conversion, Kevin Wolf, 2010/11/24
- [Qemu-devel] Re: [PATCH] scsi-generic: bugfixes for 'SCSIRequest' conversion, Hannes Reinecke, 2010/11/24
- [Qemu-devel] Re: [PATCH] scsi-generic: bugfixes for 'SCSIRequest' conversion, Kevin Wolf, 2010/11/24
- [Qemu-devel] Re: [PATCH] scsi-generic: bugfixes for 'SCSIRequest' conversion,
Hannes Reinecke <=
- Re: [Qemu-devel] Re: [PATCH] scsi-generic: bugfixes for 'SCSIRequest' conversion, Benjamin Herrenschmidt, 2010/11/25
- Re: [Qemu-devel] Re: [PATCH] scsi-generic: bugfixes for 'SCSIRequest' conversion, Gerd Hoffmann, 2010/11/25
- Re: [Qemu-devel] Re: [PATCH] scsi-generic: bugfixes for 'SCSIRequest' conversion, Benjamin Herrenschmidt, 2010/11/25
- Re: [Qemu-devel] Re: [PATCH] scsi-generic: bugfixes for 'SCSIRequest' conversion, Hannes Reinecke, 2010/11/25
- Re: [Qemu-devel] Re: [PATCH] scsi-generic: bugfixes for 'SCSIRequest' conversion, Benjamin Herrenschmidt, 2010/11/25
- Re: [Qemu-devel] Re: [PATCH] scsi-generic: bugfixes for 'SCSIRequest' conversion, Gerd Hoffmann, 2010/11/25
- [Qemu-devel] Re: [PATCH] scsi-generic: bugfixes for 'SCSIRequest' conversion, Nicholas A. Bellinger, 2010/11/24