[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCHv2 3/6] migration/savevm: no need to flush requests
From: |
Michael S. Tsirkin |
Subject: |
[Qemu-devel] [PATCHv2 3/6] migration/savevm: no need to flush requests |
Date: |
Wed, 24 Nov 2010 17:53:02 +0200 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
There's no need to flush requests after vmstop
as vmstop does it for us automatically now.
Signed-off-by: Michael S. Tsirkin <address@hidden>
Tested-by: Jason Wang <address@hidden>
---
migration.c | 2 --
savevm.c | 4 ----
2 files changed, 0 insertions(+), 6 deletions(-)
diff --git a/migration.c b/migration.c
index 9ee8b17..15f7f35 100644
--- a/migration.c
+++ b/migration.c
@@ -368,8 +368,6 @@ void migrate_fd_put_ready(void *opaque)
DPRINTF("done iterating\n");
vm_stop(0);
- qemu_aio_flush();
- bdrv_flush_all();
if ((qemu_savevm_state_complete(s->mon, s->file)) < 0) {
if (old_vm_running) {
vm_start();
diff --git a/savevm.c b/savevm.c
index 4e49765..49e78a5 100644
--- a/savevm.c
+++ b/savevm.c
@@ -1575,8 +1575,6 @@ static int qemu_savevm_state(Monitor *mon, QEMUFile *f)
saved_vm_running = vm_running;
vm_stop(0);
- bdrv_flush_all();
-
ret = qemu_savevm_state_begin(mon, f, 0, 0);
if (ret < 0)
goto out;
@@ -1885,8 +1883,6 @@ void do_savevm(Monitor *mon, const QDict *qdict)
monitor_printf(mon, "No block device can accept snapshots\n");
return;
}
- /* ??? Should this occur after vm_stop? */
- qemu_aio_flush();
saved_vm_running = vm_running;
vm_stop(0);
--
1.7.3.2.91.g446ac
[Qemu-devel] [PATCHv2 5/6] migration: stable ram block ordering, Michael S. Tsirkin, 2010/11/24