Re: [Qemu-devel] Re: [PATCH 10/12] config: Add header file for device config options

[Blue Swirl]

On Wed, Nov 24, 2010 at 10:54 AM, Alexander Graf <address@hidden> wrote:
>
> On 24.11.2010, at 03:22, Juan Quintela wrote:
>
>> Alexander Graf <address@hidden> wrote:
>>> So far we have C preprocessor defines for target and host config
>>> options, but we're lacking any information on which devices are
>>> available.
>>>
>>> We do need that information at times though, for example in the
>>> ahci patch where we need to call a legacy init function depending
>>> on whether we have support compiled in or not.
>>>
>>> So this patch makes all config-devices options available as header
>>> file. Please only include it in machine description code!
>>>
>>> Signed-off-by: Alexander Graf <address@hidden>
>>
>> This already existed in the past,  Paul Brook reverted it.
>>
>> commit a992fe3d0fc185112677286f7a02204d8245b61e
>> Author: Paul Brook <address@hidden>
>> Date:   Sun Nov 22 16:25:30 2009 +0000
>>
>>    Makefile dependencies for device configs
>>
>> I did the 1st implementation, and I tried to get it back several times.
>> Paul Brook reasoning is that "if you need it, our device model is wrong.
>>
>> If you show that you want to be able to compile out several devices, ...
>>
>> Paul Brook:  "if you need it, our device model is wrong"
>>
>> If you don't want to have the abomination of xen-stub.c kvm-stub.c,
>> etc....
>>
>> Paul Brook:  "if you need it, our device model is wrong".
>>
>> Last time I tried to get it back was to be able to compile out hpet (it
>> didn't worked well at the time).
>>
>> I let you guess how it ended.
>
> Sure, I only want to keep it in as a temporary solution in cases where 
> overhauling the device model needs a lot of thorough thought and 
> considerations.
>
> As I stated for this particular issue, maybe the way forward is to move all 
> the initialization code over to -drive instead of keeping it close to the 
> device. But I'm not sure yet. Hence this very little intrusive patch.

I read the config-devices.h thread and I agree that it's a bad idea.
So, I'm also NACKing this patch. Please adjust the code so that
CONFIG_AHCI is no longer needed.