[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH 08/25] Monitor: Convert bdrv_stats_print() into bdrv
From: |
Luiz Capitulino |
Subject: |
[Qemu-devel] [PATCH 08/25] Monitor: Convert bdrv_stats_print() into bdrv_stats() |
Date: |
Mon, 6 Dec 2010 16:23:55 -0200 |
The new handler directly calls qmp_query_blockstats() to gather
data and then prints it. This change allows us to drop the
user_print callback.
Signed-off-by: Luiz Capitulino <address@hidden>
---
block.c | 6 +++++-
block.h | 2 +-
monitor.c | 3 +--
3 files changed, 7 insertions(+), 4 deletions(-)
diff --git a/block.c b/block.c
index 2eadd70..5b89790 100644
--- a/block.c
+++ b/block.c
@@ -1671,9 +1671,13 @@ static void bdrv_stats_iter(QObject *data, void *opaque)
qdict_get_int(qdict, "wr_operations"));
}
-void bdrv_stats_print(Monitor *mon, const QObject *data)
+void bdrv_stats(Monitor *mon)
{
+ QObject *data;
+
+ qmp_query_blockstats(NULL, &data);
qlist_iter(qobject_to_qlist(data), bdrv_stats_iter, mon);
+ qobject_decref(data);
}
static QObject* bdrv_info_stats_bs(BlockDriverState *bs)
diff --git a/block.h b/block.h
index e71b6ad..ff79f02 100644
--- a/block.h
+++ b/block.h
@@ -54,7 +54,7 @@ void bdrv_mon_event(const BlockDriverState *bdrv,
BlockMonEventAction action, int is_read);
void qmp_query_block(Monitor *mon, QObject **ret_data);
void bdrv_info(Monitor *mon);
-void bdrv_stats_print(Monitor *mon, const QObject *data);
+void bdrv_stats(Monitor *mon);
void qmp_query_blockstats(Monitor *mon, QObject **ret_data);
void bdrv_init(void);
diff --git a/monitor.c b/monitor.c
index 2bdaf03..3091a1a 100644
--- a/monitor.c
+++ b/monitor.c
@@ -2416,8 +2416,7 @@ static const mon_cmd_t info_cmds[] = {
.args_type = "",
.params = "",
.help = "show block device statistics",
- .user_print = bdrv_stats_print,
- .mhandler.info_new = qmp_query_blockstats,
+ .mhandler.info = bdrv_stats,
},
{
.name = "registers",
--
1.7.3.3.398.g0b0cd
- [Qemu-devel] [PATCH v1 00/25]: Monitor: First step on an internal QMP API, Luiz Capitulino, 2010/12/06
- [Qemu-devel] [PATCH 01/25] QMP: Rename query handlers, Luiz Capitulino, 2010/12/06
- [Qemu-devel] [PATCH 03/25] Monitor: Drop balloon handlers comments, Luiz Capitulino, 2010/12/06
- [Qemu-devel] [PATCH 02/25] QMP: Drop user_print usage from the qmp_query_cmds[] table, Luiz Capitulino, 2010/12/06
- [Qemu-devel] [PATCH 04/25] Monitor: Move qmp_query_version() up in monitor.c, Luiz Capitulino, 2010/12/06
- [Qemu-devel] [PATCH 06/25] Monitor: Convert qemu_chr_info_print() into qemu_chr_info(), Luiz Capitulino, 2010/12/06
- [Qemu-devel] [PATCH 05/25] Monitor: Convert do_info_version_print() into do_info_version(), Luiz Capitulino, 2010/12/06
- [Qemu-devel] [PATCH 07/25] Monitor: Convert bdrv_info_print() into bdrv_info(), Luiz Capitulino, 2010/12/06
- [Qemu-devel] [PATCH 08/25] Monitor: Convert bdrv_stats_print() into bdrv_stats(),
Luiz Capitulino <=
- [Qemu-devel] [PATCH 09/25] Monitor: Move qmp_query_cpus() up in monitor.c, Luiz Capitulino, 2010/12/06
- [Qemu-devel] [PATCH 10/25] Monitor: Convert monitor_print_cpus() into do_info_cpus(), Luiz Capitulino, 2010/12/06
- [Qemu-devel] [PATCH 11/25] Monitor: Convert do_pci_info_print() into do_pci_info(), Luiz Capitulino, 2010/12/06
- [Qemu-devel] [PATCH 13/25] Monitor: Convert do_info_kvm_print() into do_info_kvm(), Luiz Capitulino, 2010/12/06
- [Qemu-devel] [PATCH 14/25] Monitor: Move qmp_query_status() up in monitor.c, Luiz Capitulino, 2010/12/06
- [Qemu-devel] [PATCH 15/25] Monitor: Convert do_info_status_print() into do_info_status(), Luiz Capitulino, 2010/12/06
- [Qemu-devel] [PATCH 16/25] Monitor: Convert do_info_mice_print() into do_info_mice(), Luiz Capitulino, 2010/12/06
- [Qemu-devel] [PATCH 17/25] Monitor: Convert do_info_vnc_print() into do_info_vnc(), Luiz Capitulino, 2010/12/06
- [Qemu-devel] [PATCH 19/25] Monitor: Convert do_info_name_print() into do_info_name(), Luiz Capitulino, 2010/12/06
- [Qemu-devel] [PATCH 18/25] Monitor: Move qmp_query_name() up in monitor.c, Luiz Capitulino, 2010/12/06