[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] Re: [PATCH 4/5] virtio-serial: Don't copy over guest buffer
|
From: |
Amit Shah |
|
Subject: |
[Qemu-devel] Re: [PATCH 4/5] virtio-serial: Don't copy over guest buffer to host |
|
Date: |
Fri, 10 Dec 2010 20:29:57 +0530 |
|
User-agent: |
Mutt/1.5.21 (2010-09-15) |
On (Fri) Dec 10 2010 [14:02:37], Paul Brook wrote:
> > - if (!discard) {
> > + if (discard) {
> > + goto next;
> > + }
>
> > + next:
> > virtqueue_push(vq, &elem, 0);
>
> Please don't do this.
Could you elaborate?
I can move the 'discard' check into the following 'for' loop, but since
the value of discard doesn't change, I moved it outside.
Amit
[Qemu-devel] [PATCH 5/5] virtio-serial: Error out if guest sends unexpected vq elements, Amit Shah, 2010/12/10