Re: [Qemu-devel] [PATCH] wdt_i6300esb: register a reset function

[Blue Swirl]

Thanks, applied.

On Sun, Dec 12, 2010 at 11:15 AM, Richard W.M. Jones <address@hidden> wrote:
> On Sun, Dec 12, 2010 at 10:59:59AM +0000, Blue Swirl wrote:
>> On Sun, Dec 12, 2010 at 10:08 AM, Richard W.M. Jones <address@hidden> wrote:
>> > On Sat, Dec 11, 2010 at 06:39:03PM +0000, Blue Swirl wrote:
>> >> Thanks, applied.
>> >
>> > Wait!  This patch is incomplete.
>> >
>> > I already posted a complete patch already some months ago (twice) but
>> > it was ignored both times:
>> >
>> > http://www.mail-archive.com/address@hidden/msg42716.html
>> > http://www.mail-archive.com/address@hidden/msg43142.html
>>
>> The difference is that previous_reboot_flag should not be cleared in
>> reset, right?
>
> Yes, and:
>
> - Bernhard removed the call to i6300esb_reset after the watchdog
> fires.  I'm not sure why this was done, since AFAIK the watchdog
> should be completely reset by this event (as in a real machine).
>
> - The same change is needed to IB700 as well.
>
>> Could you make a new patch, please?
>
> New patch attached.
>
> Rich.
>
> --
> Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
> virt-p2v converts physical machines to virtual machines.  Boot with a
> live CD or over the network (PXE) and turn machines into Xen guests.
> http://et.redhat.com/~rjones/virt-p2v
>