[Qemu-devel] Re: [PATCH] rtl8139: IO memory is not part of vmstate

[Juan Quintela]

"Michael S. Tsirkin" <address@hidden> wrote:
> On Sun, Dec 12, 2010 at 05:23:39PM +0530, Juan Quintela wrote:
>> "Michael S. Tsirkin" <address@hidden> wrote:
>> > On Thu, Dec 09, 2010 at 03:14:17PM -0700, Alex Williamson wrote:

>> > How about we keep migrating the index for the benefit of
>> > old versions, but ignore the value on load?
>> > Something like the following:
>> 
>> This was my 1st suggestion to Alex O:-)
>
> The difference here is that instead of sending garbage to the
> old version we send an actual index value.
>
>> So, I am in.  he think this is bad for upstream,  I don't think so (but
>> I understand that it is oppinable).
>> 
>> Later, Juan.
>
> I think it makes sense to fix this for the stable branch,
> and I think we should try as hard as we can to avoid bumping up the
> version number there.
>
> For master we can bump the version number but it might be easier to
> just keep the code the same there.

I think that your solution is better.  For older versions, it works as
expected.  For new versions, problem is fixed.  Solution is not the
"purest", but you can say the same about uping the version for a state
that is exactly the same length & fields O:-)

Later, Juan.