[Qemu-devel] Re: [PATCH 1/5] block: add discard support

[Paolo Bonzini]

On 12/13/2010 05:15 PM, Christoph Hellwig wrote:
> On Mon, Dec 13, 2010 at 05:07:27PM +0100, Paolo Bonzini wrote:
> > On 12/10/2010 02:38 PM, Christoph Hellwig wrote:
> > > if it's smaller than the block size we'll zero out the remainder of
> > > the block.
> >
> > I think it should fail at VM startup time, or even better do nothing at all.
>
> What should fail?

Nothing -- you wrote "if it's smaller than the block size we'll zero out 
the remainder of the block" which I interpreted the wrong way, i.e. as 
"XFS will round up the size to the remainder of the block and zero that 
part out as well".

Thanks for the clarification.

Paolo