|
From: | Avi Kivity |
Subject: | [Qemu-devel] Re: [PATCH v4 2/2] RAM API: Make use of it for x86 PC |
Date: | Tue, 14 Dec 2010 11:18:25 +0200 |
User-agent: | Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.13) Gecko/20101209 Fedora/3.1.7-0.35.b3pre.fc14 Lightning/1.0b3pre Thunderbird/3.1.7 |
On 12/13/2010 11:24 PM, Alex Williamson wrote:
Register the actual VM RAM using the new API @@ -913,14 +913,11 @@ void pc_memory_init(ram_addr_t ram_size, /* allocate RAM */ ram_addr = qemu_ram_alloc(NULL, "pc.ram", below_4g_mem_size + above_4g_mem_size); - cpu_register_physical_memory(0, 0xa0000, ram_addr); - cpu_register_physical_memory(0x100000, - below_4g_mem_size - 0x100000, - ram_addr + 0x100000); + ram_register(0, below_4g_mem_size, ram_addr);
What's the impact of this? Won't it conflict with BIOS memory registration? What about VGA?
In terms of patch hygiene, it should be in a separate patch titled "register 0xa0000-0x100000 as RAM" or something. It's a much more drastic change than making use of the new RAM API.
-- error compiling committee.c: too many arguments to function
[Prev in Thread] | Current Thread | [Next in Thread] |