[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 1/1] qemu-img.c: Clean up handling of image s
From: |
Markus Armbruster |
Subject: |
Re: [Qemu-devel] [PATCH v2 1/1] qemu-img.c: Clean up handling of image size in img_create() |
Date: |
Wed, 15 Dec 2010 18:23:06 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/23.1 (gnu/linux) |
Jes Sorensen <address@hidden> writes:
> On 12/15/10 17:47, Markus Armbruster wrote:
>> address@hidden writes:
>>
>>> From: Jes Sorensen <address@hidden>
>>>
>>> This cleans up the handling of image size in img_create() by parsing
>>> the value early, and then only setting it once if a value has been
>>> added as the last argument to the command line.
>>>
>>> Signed-off-by: Jes Sorensen <address@hidden>
>>> ---
>>> qemu-img.c | 14 ++++++++------
>>> 1 files changed, 8 insertions(+), 6 deletions(-)
>>>
>>
>> Patch conflicts with commit c2abccec.
>
> ARGH :(
>
>> This switches parsing of the size argument from parse_option_size() (via
>> set_option_parameter()) to strtosz(). I'm fine with that, but:
>>
>> * Before:
>>
>> $ qemu-img create xxx xxx
>> Parameter 'size' expects a size
>> You may use k, M, G or T suffixes for kilobytes, megabytes, gigabytes
>> and terabytes.
>> qemu-img: Image creation needs a size parameter
>>
>> * After:
>>
>> $ qemu-img create xxx xxx
>> qemu-img: Image creation needs a size parameter
>>
>> Intentional?
>
> This was addressed in the later revision when I introduced strtosz_suffix()
Looks like I'm getting lost in my post-vacation mail backlog %-}