[Qemu-devel] Re: [PATCH v3 0/4] Re-factor img_create() and add live snapshots

[Kevin Wolf]

Am 16.12.2010 13:52, schrieb address@hidden:
> From: Jes Sorensen <address@hidden>
> 
> Hi,
> 
> This set of patches re-factors img_create() and moves the core part of
> it into block.c so it can be accessed from qemu as well as
> qemu-img. The second patch adds basic live snapshots support to the
> code, however only snapshots to external QCOW2 images is supported for
> now. QED support should be trivial once the QED patches go into
> upstream.
> 
> The last patch fixes a small gotcha which is present in the old code
> as well. Try to catch cases where a user tries to create an image with
> itself as the backing file. QEMU does 'interesting' things when you do
> this.....
> 
> Many thanks to Kevin for his help with block layer internals!
> 
> New in v2:
>  - Fix error return value in monitor command
>  - Clarify help message for command
>  - Fix patch conflict against block tree. It's all Stefan's fault :)
>    f8feb11f4d76f390dddc5cc5345abf99f7659a78
> 
> New in v3:
>  - Address issues pointed out by Stefan and Kevin
>  - Additional patch to return proper -errno error values on error in
>    bdrv_img_create() as suggested by Kevin.
> 
> Jes Sorensen (4):
>   qemu-img.c: Re-factor img_create()
>   Introduce do_snapshot_blkdev() and monitor command to handle it.
>   Prevent creating an image with the same filename as backing file
>   bdrv_img_create() use proper errno return values
> 
>  block.c         |  145 
> +++++++++++++++++++++++++++++++++++++++++++++++++++++++
>  block.h         |    4 ++
>  blockdev.c      |   62 +++++++++++++++++++++++
>  blockdev.h      |    1 +
>  hmp-commands.hx |   19 +++++++
>  qemu-img.c      |  108 +----------------------------------------
>  6 files changed, 233 insertions(+), 106 deletions(-)

Thanks, applied all to the block branch.

Kevin