qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-devel] Re: [PATCH v5 0/4] virtio: Use ioeventfd for virtqueue noti


From: Michael S. Tsirkin
Subject: [Qemu-devel] Re: [PATCH v5 0/4] virtio: Use ioeventfd for virtqueue notify
Date: Fri, 17 Dec 2010 01:39:15 +0200
User-agent: Mutt/1.5.21 (2010-09-15)

On Thu, Dec 16, 2010 at 04:40:32PM +0000, Stefan Hajnoczi wrote:
> On Wed, Dec 15, 2010 at 12:59 PM, Stefan Hajnoczi <address@hidden> wrote:
> > On Wed, Dec 15, 2010 at 12:14 PM, Michael S. Tsirkin <address@hidden> wrote:
> >> On Wed, Dec 15, 2010 at 11:42:12AM +0000, Stefan Hajnoczi wrote:
> >>> Are you happy with this patchset if I remove virtio-net-pci
> >>> ioeventfd=on|off so only virtio-blk-pci has ioeventfd=on|off (with
> >>> default on)?  For block we've found it to be a win and the initial
> >>> results looked good for net too.
> 
> Please let me know if I should disable ioeventfd for virtio-net.
> 
> Stefan

Sure, if it slows us down, we should disable it.
What bothers me is the API issue that makes ioeventfd an all or nothing
thing, so it's enabled for the control vq needs to be resolved anyway.

Still it does not affect block, so maybe we can merge as is
and fix later ... I will try to think it over on the weekend.

-- 
MST



reply via email to

[Prev in Thread] Current Thread [Next in Thread]