Re: [Qemu-devel] Re: [PATCH] win32: Fix CRLF problem in make_device_config.sh

[Andreas Färber]

Am 16.12.2010 um 23:42 schrieb Paolo Bonzini:

> On 12/16/2010 10:52 PM, Stefan Weil wrote:
> > QEMU source code with CRLF line endings
> > which is quite common on windows hosts
> > fails with current make_device_config.sh.
> >
> > The awk script gets the name of the included
> > file with \r, so instead of pci.mak it will
> > search for pci.mak\r which of course does
> > not work.
> >
> > Fix this by removing any \r at end of line.
>
> Why isn't cygwin (or whatever you're using) removing it?

I believe Cygwin had an option to choose the line ending style once  
during setup. By default it uses Unix-style line endings.
If someone edits source files in some Windows editor, the above issue  
seems likely.

My awk foo is insufficient to ack the patch but if it doesn't break  
Unices it looks reasonable to me.

Andreas