[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] Re: [PATCH v2] ide: Register vm change state handler on
|
From: |
Kevin Wolf |
|
Subject: |
Re: [Qemu-devel] Re: [PATCH v2] ide: Register vm change state handler once only |
|
Date: |
Fri, 17 Dec 2010 19:46:03 +0100 |
|
User-agent: |
Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.15) Gecko/20101027 Fedora/3.0.10-1.fc12 Thunderbird/3.0.10 |
Am 17.12.2010 19:35, schrieb Andreas Färber:
> Am 17.12.2010 um 14:12 schrieb Kevin Wolf:
>
>> Am 16.12.2010 16:54, schrieb Stefan Hajnoczi:
>>> We register the vm change state handler in a PCI BAR map() function.
>>> This function can be called multiple times throughout the lifetime
>>> of a
>>> PCI IDE device. This results in duplicate vm change state handlers
>>> being register, none of which are ever unregistered.
>>>
>>> Instead, register the vm change state handler in the device's init
>>> function once and for all.
>>>
>>> piix tested, cmd646 and via not tested.
>>>
>>> Signed-off-by: Stefan Hajnoczi <address@hidden>
>>
>> Thanks, applied to the block branch.
>
> This just landed in master and breaks the build due to use of an
> undefined variable bm in hw/ide/cmd646.c...
Can you try the patch I just sent?
Kevin