[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] Re: [PATCH v2 2/2] qemu, qmp: convert do_inject_nmi() to QO
From: |
Marcelo Tosatti |
Subject: |
[Qemu-devel] Re: [PATCH v2 2/2] qemu, qmp: convert do_inject_nmi() to QObject, QError |
Date: |
Mon, 20 Dec 2010 08:47:46 -0200 |
User-agent: |
Mutt/1.5.20 (2009-08-17) |
On Fri, Dec 10, 2010 at 09:20:26AM -0200, Luiz Capitulino wrote:
> On Fri, 10 Dec 2010 14:36:08 +0800
> Lai Jiangshan <address@hidden> wrote:
>
> > +SQMP
> > +inject_nmi
> > +----------
> > +
> > +Inject an NMI on the given CPU (x86 only).
> > +
> > +Arguments:
> > +
> > +- "cpu_index": the index of the CPU to be injected NMI (json-int)
> > +
> > +Example:
> > +
> > +-> { "execute": "inject_nmi", "arguments": { "cpu_index": 0 } }
> > +<- { "return": {} }
> > +
> > +EQMP
> > +
>
> Avi, Anthony, can you please review this? Do we expect some kind of ack from
> the guest? Do we expect it respond in some way?
Looks good to me. Don't except any response from the guest.
> Also note that the current series defines only one error condition: invalid
> cpu index. Can this fail in other ways?
> --
Not really. An NMI can be pending already (which means the current
command has no effect), but i don't see the need to report that.
- [Qemu-devel] [PATCH v2 2/2] qemu, qmp: convert do_inject_nmi() to QObject, QError, Lai Jiangshan, 2010/12/10
- [Qemu-devel] Re: [PATCH v2 2/2] qemu, qmp: convert do_inject_nmi() to QObject, QError, Markus Armbruster, 2010/12/10
- [Qemu-devel] Re: [PATCH v2 2/2] qemu, qmp: convert do_inject_nmi() to QObject, QError, Luiz Capitulino, 2010/12/10
- [Qemu-devel] Re: [PATCH v2 2/2] qemu, qmp: convert do_inject_nmi() to QObject, QError,
Marcelo Tosatti <=