[Qemu-devel] Re: [PATCH v2] target-arm: fix UMAAL instruction

[Peter Maydell]

On 31 December 2010 20:54, Aurelien Jarno <address@hidden> wrote:
> UMAAL should use unsigned multiply instead of signed.
>
> This patch fixes this issue by handling UMAAL separately from
> UMULL/UMLAL/SMULL/SMLAL as these instructions are different
> enough. It also explicitly list instructions in case and catch
> nonexistent instruction as illegal. Also fixes a few style issues.
>
> This fixes the issues reported in
> https://bugs.launchpad.net/qemu/+bug/696015
>
> Cc: Peter Maydell <address@hidden>
> Signed-off-by: Aurelien Jarno <address@hidden>

Thanks for the tweaks, looks good to me.

Reviewed-by: Peter Maydell <address@hidden>

-- PMM