[Qemu-devel] Re: [PATCH v2] target-arm: fix UMAAL instruction

[Aurelien Jarno]

On Fri, Dec 31, 2010 at 09:09:04PM +0000, Peter Maydell wrote:
> On 31 December 2010 20:54, Aurelien Jarno <address@hidden> wrote:
> > UMAAL should use unsigned multiply instead of signed.
> >
> > This patch fixes this issue by handling UMAAL separately from
> > UMULL/UMLAL/SMULL/SMLAL as these instructions are different
> > enough. It also explicitly list instructions in case and catch
> > nonexistent instruction as illegal. Also fixes a few style issues.
> >
> > This fixes the issues reported in
> > https://bugs.launchpad.net/qemu/+bug/696015
> >
> > Cc: Peter Maydell <address@hidden>
> > Signed-off-by: Aurelien Jarno <address@hidden>
> 
> Thanks for the tweaks, looks good to me.
> 
> Reviewed-by: Peter Maydell <address@hidden>
> 

Thanks for the review, committed.

-- 
Aurelien Jarno                          GPG: 1024D/F1BCDB73
address@hidden                 http://www.aurel32.net