[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] Re: [PATCH v2 11/17] kvm: x86: Reset paravirtual MSRs
From: |
Jan Kiszka |
Subject: |
[Qemu-devel] Re: [PATCH v2 11/17] kvm: x86: Reset paravirtual MSRs |
Date: |
Mon, 03 Jan 2011 17:46:04 +0100 |
User-agent: |
Mozilla/5.0 (X11; U; Linux i686 (x86_64); de; rv:1.8.1.12) Gecko/20080226 SUSE/2.0.0.12-1.1 Thunderbird/2.0.0.12 Mnenhy/0.7.5.666 |
Am 03.01.2011 17:40, Glauber Costa wrote:
> On Mon, 2011-01-03 at 09:33 +0100, Jan Kiszka wrote:
>> From: Jan Kiszka <address@hidden>
>>
>> Make sure to clear MSR_KVM_SYSTEM_TIME, MSR_KVM_WALL_CLOCK, and
>> MSR_KVM_ASYNC_PF_EN so that a freshly booted guest cannot be disturbed
>> by old values.
>>
>> Signed-off-by: Jan Kiszka <address@hidden>
>> CC: Glauber Costa <address@hidden>
>> ---
>> target-i386/kvm.c | 10 ++++++++++
>> 1 files changed, 10 insertions(+), 0 deletions(-)
>>
>> diff --git a/target-i386/kvm.c b/target-i386/kvm.c
>> index d8f26bf..664a4a0 100644
>> --- a/target-i386/kvm.c
>> +++ b/target-i386/kvm.c
>> @@ -453,6 +453,9 @@ void kvm_arch_reset_vcpu(CPUState *env)
>> env->nmi_injected = 0;
>> env->nmi_pending = 0;
>> env->xcr0 = 1;
>> + env->system_time_msr = 0;
>> + env->wall_clock_msr = 0;
>> + env->async_pf_en_msr = 0;
>
> Have you seen this happening? I'd expect CPUState to be zeroed out over
> init. And if it is not, I guess we should...
Ah, true, those three are part of the section that is zeroed. Will drop
that hunk on repost.
Guess we should rather move some other variables in that region too and
avoid clearing them manually like above...
Jan
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] Re: [PATCH v2 14/17] kvm: x86: Introduce kvmclock device to save/restore its state, (continued)
[Qemu-devel] [PATCH v2 15/17] kvm: Drop smp_cpus argument from init functions, Jan Kiszka, 2011/01/03
[Qemu-devel] [PATCH v2 11/17] kvm: x86: Reset paravirtual MSRs, Jan Kiszka, 2011/01/03
[Qemu-devel] [PATCH v2 13/17] kvm: Eliminate KVMState arguments, Jan Kiszka, 2011/01/03
[Qemu-devel] [PATCH v2 06/17] kvm: x86: Align kvm_arch_put_registers code with comment, Jan Kiszka, 2011/01/03
[Qemu-devel] [PATCH v2 10/17] kvm: x86: Refactor msr_star/hsave_pa setup and checks, Jan Kiszka, 2011/01/03
[Qemu-devel] [PATCH v2 17/17] kvm: Drop dependencies on very old capabilities, Jan Kiszka, 2011/01/03