[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] Re: [PATCH] ioeventfd: minor fixups
From: |
Stefan Hajnoczi |
Subject: |
[Qemu-devel] Re: [PATCH] ioeventfd: minor fixups |
Date: |
Tue, 4 Jan 2011 10:28:33 +0000 |
User-agent: |
Mutt/1.5.20 (2009-06-14) |
On Mon, Jan 03, 2011 at 06:38:53PM +0200, Michael S. Tsirkin wrote:
> On Wed, Dec 29, 2010 at 04:52:46PM +0200, Michael S. Tsirkin wrote:
> > This is on top of the ioeventfd patches, and
> > fixes two potential issues when ioeventfd is mixed with vhost-net:
> > - ioeventfd could start running then get stopped for vhost-net.
> > For example, vm state change handlers run in no particular order.
> > This would be hard to debug. Prevent this by always running state
> > callback before ioeventfd start and after ioeventfd stop.
> > - Separate the flags for user-requested ioeventfd and for ioeventfd
> > being overridden by vhost backend.
> > This will make it possible to enable/disable vhost depending on
> > guest behaviour.
> >
> > I'll probably split this patch in two, and merge into the
> > appropriate patches in the ioeventfd series.
> >
> > Compile-tested only so far, would appreciate feedback/test reports.
> >
> > Signed-off-by: Michael S. Tsirkin <address@hidden>
>
>
> Stefan - just to clarify, I'm waiting for you ack
> to merge this + the ioeventfd patches.
Back from the holidays today. Will send feedback/ack later today.
Stefan