qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-devel] Re: [PATCH v3 15/21] kvm: x86: Introduce kvmclock device to


From: Jan Kiszka
Subject: [Qemu-devel] Re: [PATCH v3 15/21] kvm: x86: Introduce kvmclock device to save/restore its state
Date: Tue, 04 Jan 2011 12:45:05 +0100
User-agent: Mozilla/5.0 (X11; U; Linux i686 (x86_64); de; rv:1.8.1.12) Gecko/20080226 SUSE/2.0.0.12-1.1 Thunderbird/2.0.0.12 Mnenhy/0.7.5.666

Am 04.01.2011 12:43, Glauber Costa wrote:
> On Tue, 2011-01-04 at 12:34 +0100, Jan Kiszka wrote:
>> Am 04.01.2011 12:08, Glauber Costa wrote:
>>> On Tue, 2011-01-04 at 09:32 +0100, Jan Kiszka wrote:
>>>> From: Jan Kiszka <address@hidden>
>>>>
>>>> If kvmclock is used, which implies the kernel supports it, register a
>>>> kvmclock device with the sysbus. Its main purpose is to save and restore
>>>> the kernel state on migration, but this will also allow to visualize it
>>>> one day.
>>>
>>> I would prefer having no pre-save, and doing the ioctl in the state
>>> change handler. But I won't nitpick about that, if the maintainers think
>>> this is okay, all the rest of the patch looks fine as well.
>>
>> I did this for a reason: to be able to obtain the current clock state
>> even while the vm is running. It's cleaner IMHO.
> 
> but if we're on pre-save, we are certain that the vm is stopped at this
> moment, no ?

Maybe at the moment, but not for device state dumping or maybe (dunno)
for Kemari's continuous sync'ing. I simply want to avoid this implicit
dependency.

Jan

Attachment: signature.asc
Description: OpenPGP digital signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]