Re: [Qemu-devel] [PATCH] Add VMX cpuid feature to qemu64

[Alexander Graf]

On 04.01.2011, at 16:06, Nadav Har'El wrote:

> This patch adds the "VMX" cpuid feature to the default "qemu64" CPU type.
> If KVM doesn't support this feature (i.e., nested VMX is not in the code,
> or not enabled) it will mask out this bit.

"qemu64" defines capabilities that qemu emulates. Qemu does not emulate VMX. So 
it doesn't belong there. I thought we had a "kvm64" type for your use case?

> Note that other relevant CPU types, such as "core2duo" already correctly
> include the VMX feature, and "qemu64" already includes the SVM feature

"core2duo" really shouldn't include VMX as qemu simply can't emulate it. Qemu 
does emulate SVM, hence the bit in the "qemu64" type.


Alex