qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v2 2/8] softfloat: use bits32 instead of uint32


From: Andreas Färber
Subject: Re: [Qemu-devel] [PATCH v2 2/8] softfloat: use bits32 instead of uint32
Date: Tue, 4 Jan 2011 20:23:54 +0100

Am 04.01.2011 um 17:11 schrieb Aurelien Jarno:

On Tue, Jan 04, 2011 at 03:51:37PM +0000, Peter Maydell wrote:
On 4 January 2011 15:15, Aurelien Jarno <address@hidden> wrote:
Use bits32 instead of uint32 when manipulating floating point values
directly for consistency reasons.

I'm not convinced this patch is particularly worthwhile, especially since
Andreas is working on a patchset which will convert all the bits32
uses back into uint32_t anyway, which is the direction to go if we
want to make the fpu/ code consistent about its type usage.

I don't know in which direction we should go (bits32 or uint32_t), but
we should go for more consistency. When everything is consistent, it's
just a regex to go switch the type.

Please don't introduce new uses of bits*. There's simply no reason to have such types in a C99 project.

Unfortunately the new year started with hardware failure for me, so I haven't found the time to continue work on the series yet. I'll send a rebased v4 shortly, patch 5/7 v3 was broken by a change to softfloat- specialize.h.

Andreas



reply via email to

[Prev in Thread] Current Thread [Next in Thread]