Re: [Qemu-devel] [PATCH] Add VMX cpuid feature to qemu64

[Avi Kivity]

On 01/05/2011 10:17 AM, Nadav Har'El wrote:
> On Tue, Jan 04, 2011, Alexander Graf wrote about "Re: [Qemu-devel] [PATCH] Add VMX 
> cpuid feature to qemu64":
> >  If qemu-kvm still uses the "qemu64" type, that's plainly a bug :). It really 
> should use -cpu kvm64 / kvm32 as default.
>
> When I run qemu-kvm's qemu-system-x86_64, and look at the CPU I get in the
> guest, I the CPU is clearly "QEMU Virtual CPU version 0.13.50" (qemu64) and
> not "Common KVM processor" (kvm64) the "-enable-kvm" option doesn't appear to
> change anything. Could this have always been a bug, which remained hidden
> in plain sight? :-)
>
> If I send a patch to default to kvm64, not qemu64, when KVM is being used,
> would that be acceptable by all parties involved (KVM people and QEMU people)?

The intent of kvm64/qemu64 is to provide some feature stability, so that 
when you run a guest with those cpu types, you get something expected.  
So adding to them isn't a good idea.

I think we'd be fine with -cpu host and -cpu qemu64,+vmx enabling vmx 
support.


--
error compiling committee.c: too many arguments to function