[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] Re: [PATCH] Make strtosz() return int64_t instead of ssize_
|
From: |
Jes Sorensen |
|
Subject: |
[Qemu-devel] Re: [PATCH] Make strtosz() return int64_t instead of ssize_t |
|
Date: |
Wed, 05 Jan 2011 15:40:22 +0100 |
|
User-agent: |
Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.13) Gecko/20101209 Fedora/3.1.7-0.35.b3pre.fc14 Lightning/1.0b3pre Thunderbird/3.1.7 |
On 01/05/11 14:46, Anthony Liguori wrote:
> On 01/05/2011 04:41 AM, address@hidden wrote:
>> From: Jes Sorensen<address@hidden>
>>
>> strtosz() needs to return a 64 bit type even on 32 bit
>> architectures. Otherwise qemu-img will fail to create disk
>> images>= 2GB
>>
>> Signed-off-by: Jes Sorensen<address@hidden>
>>
>
> off_t would be the proper type to use.
I discussed this with Markus, and we both agree that it isn't.
Two reasons, off_t is for filesystem offsets, not random sizes. Second,
off_t doesn't have an unsigned type or a max to compare against.
Using int64_t is cleaner and safer.
Cheers,
Jes