[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] Re: [PATCH 03/13] Add callback function to ThreadletWork st
From: |
Arun R Bharadwaj |
Subject: |
[Qemu-devel] Re: [PATCH 03/13] Add callback function to ThreadletWork structure. |
Date: |
Thu, 6 Jan 2011 15:54:09 +0530 |
User-agent: |
Mutt/1.5.20 (2009-06-14) |
* Stefan Hajnoczi <address@hidden> [2011-01-05 19:54:17]:
> On Tue, Jan 04, 2011 at 10:57:20AM +0530, Arun R Bharadwaj wrote:
> > +static void aio_thread(ThreadletWork *work)
> > +{
>
> aio_thread() is not a descriptive name here. This isn't the top-level
> thread function, just the work->func. Please choose something like
> handle_aiocb() or handle_work().
>
> > + pid_t pid;
> > + ssize_t ret = 0;
> > + struct qemu_paiocb *aiocb;
> > +
> > + pid = getpid();
> > + aiocb = container_of(work, struct qemu_paiocb, work);
> > + aiocb->active = 1;
>
> aiocb_mutex?
>
I'll take care of this.
-arun
- [Qemu-devel] [PATCH 00/13] Threadlets infrastructure., Arun R Bharadwaj, 2011/01/04
- [Qemu-devel] [PATCH 01/13] Add aiocb_mutex and aiocb_completion., Arun R Bharadwaj, 2011/01/04
- [Qemu-devel] [PATCH 02/13] Introduce work concept in posix-aio-compat.c, Arun R Bharadwaj, 2011/01/04
- [Qemu-devel] [PATCH 03/13] Add callback function to ThreadletWork structure., Arun R Bharadwaj, 2011/01/04
- [Qemu-devel] [PATCH 04/13] Add ThreadletQueue., Arun R Bharadwaj, 2011/01/04
- [Qemu-devel] [PATCH 05/13] Threadlet: Add submit_work threadlet API., Arun R Bharadwaj, 2011/01/04
- [Qemu-devel] [PATCH 06/13] Threadlet: Add dequeue_work threadlet API, Arun R Bharadwaj, 2011/01/04
- [Qemu-devel] [PATCH 07/13] Remove active field in qemu_aiocb structure., Arun R Bharadwaj, 2011/01/04
- [Qemu-devel] [PATCH 08/13] Remove thread_create routine., Arun R Bharadwaj, 2011/01/04