Re: [Qemu-devel] [PATCH 1/6] softfloat: remove HPPA specific code

[Stuart Brady]

On Thu, Jan 06, 2011 at 06:43:28PM +0000, Peter Maydell wrote:
> On 6 January 2011 18:13, Stuart Brady <address@hidden> wrote:
> > On Thu, Jan 06, 2011 at 08:58:17AM +0000, Peter Maydell wrote:
> >> On 5 January 2011 23:13, Stuart Brady <address@hidden> wrote:
> >> > I do have a few concerns regarding SoftFloat, though:
> >> >
> >> >   FIXMEs should be left in the code (or a document maintained on the
> >> >   Wiki) to keep track of which architectures have been considered
> >> >   (which I believe are x86, arm, mips, ppc) and which ones haven't.
> >> >   This is in reference to one particular FIXME that was removed,
> >> >   but perhaps shouldn't have been.
[...]
> >   /* FIXME: Flush-To-Zero only effects results.  Denormal inputs should
> >      also be flushed to zero.  */
> 
> The point of that FIXME is that it is saying "softfloat doesn't implement
> the feature of flushing denormal inputs to zero". The patch implements
> that feature in softfloat. Therefore the FIXME should be removed,
> because it has been fixed :-)

Agreed, although note that I never insisted that the FIXME be kept in
this instance -- I was just concerned that this might be forgotten
for other targets.

If we accept that those targets are likely to be buggy, and that this
is an issue for the maintainers of those targets, that sounds fine,
but I just thought I'd ask.

Cheers,
-- 
Stuart Brady