[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] Re: [PATCH V2] savevm: use error_report for vmstate_save er
From: |
Jan Kiszka |
Subject: |
[Qemu-devel] Re: [PATCH V2] savevm: use error_report for vmstate_save error |
Date: |
Fri, 07 Jan 2011 17:03:49 +0100 |
User-agent: |
Mozilla/5.0 (X11; U; Linux i686 (x86_64); de; rv:1.8.1.12) Gecko/20080226 SUSE/2.0.0.12-1.1 Thunderbird/2.0.0.12 Mnenhy/0.7.5.666 |
Am 07.01.2011 16:58, Alex Williamson wrote:
> If migration is done in the background with the -d option, mon is
> NULL and this error message is lost. Instead use error_report().
>
> Signed-off-by: Alex Williamson <address@hidden>
Reviewed-by: Jan Kiszka <address@hidden>
As already at it: Is this the only error during migration that can get
lost this way?
Jan
> ---
>
> savevm.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/savevm.c b/savevm.c
> index 90aa237..148871d 100644
> --- a/savevm.c
> +++ b/savevm.c
> @@ -1543,7 +1543,7 @@ int qemu_savevm_state_complete(Monitor *mon, QEMUFile
> *f)
>
> r = vmstate_save(f, se);
> if (r < 0) {
> - monitor_printf(mon, "cannot migrate with device '%s'\n",
> se->idstr);
> + error_report("cannot migrate with device '%s'\n", se->idstr);
> return r;
> }
> }
>
signature.asc
Description: OpenPGP digital signature
[Qemu-devel] [PATCH v3] savevm: Fix no_migrate, Alex Williamson, 2011/01/07
[Qemu-devel] [PATCH v4] savevm: Fix no_migrate, Alex Williamson, 2011/01/07
[Qemu-devel] Re: [PATCH v4] savevm: Fix no_migrate, Michael S. Tsirkin, 2011/01/09
[Qemu-devel] Re: [PATCH v4] savevm: Fix no_migrate, Michael S. Tsirkin, 2011/01/09