qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-devel] Re: [PATCH V2] savevm: use error_report for vmstate_save er


From: Jan Kiszka
Subject: [Qemu-devel] Re: [PATCH V2] savevm: use error_report for vmstate_save error
Date: Fri, 07 Jan 2011 17:27:10 +0100
User-agent: Mozilla/5.0 (X11; U; Linux i686 (x86_64); de; rv:1.8.1.12) Gecko/20080226 SUSE/2.0.0.12-1.1 Thunderbird/2.0.0.12 Mnenhy/0.7.5.666

Am 07.01.2011 17:10, Alex Williamson wrote:
> On Fri, 2011-01-07 at 17:03 +0100, Jan Kiszka wrote:
>> Am 07.01.2011 16:58, Alex Williamson wrote:
>>> If migration is done in the background with the -d option, mon is
>>> NULL and this error message is lost.  Instead use error_report().
>>>
>>> Signed-off-by: Alex Williamson <address@hidden>
>>
>> Reviewed-by: Jan Kiszka <address@hidden>
>>
>> As already at it: Is this the only error during migration that can get
>> lost this way?
> 
> On the migration source side, I think so.  All the save callbacks are
> return void, so device saves aren't allow to fail.  The unmigratable
> device registration is the only way I know to trigger an error on this
> end.  Thanks,

Hmm, thinking about this again, wouldn't it be a better user experience
to check this in advance, at a time where the issuing console is still
listening?

Jan

Attachment: signature.asc
Description: OpenPGP digital signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]