Re: [Qemu-devel] [PATCH 1/2] Add checkpatch.pl from Linux kernel

[Stefan Weil]

Am 09.01.2011 12:45, schrieb Blue Swirl:
> Unchanged import from
> http://www.kernel.org/pub/linux/kernel/people/apw/checkpatch/checkpatch.pl-0.31
>
> Signed-off-by: Blue Swirl <address@hidden>
> ---
> checkpatch.pl-0.31 | 2937 
> ++++++++++++++++++++++++++++++++++++++++++++++++++++
> 1 files changed, 2937 insertions(+), 0 deletions(-)
> create mode 100644 checkpatch.pl-0.31
>
> diff --git a/checkpatch.pl-0.31 b/checkpatch.pl-0.31
> new file mode 100644
> index 0000000..cd51a65
> --- /dev/null
> +++ b/checkpatch.pl-0.31

[snip]

I appreciate that it will be possible to use scripts like this one
for QEMU, too. Let me just add a small remark.

QEMU's root directory is already crowded with too many files
(at least that's my personal opinion).

Why not use a directory structure similar to Linux and add
the script to scripts/checkpatch.pl? More scripts will follow,
e.g. scripts/get_maintainer.pl, and users will know where they
have to look for these scripts.

Regards,
Stefan