qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [RFC][PATCH] lsi53c895a: Update dnad when skipping MSGO


From: Stefan Hajnoczi
Subject: Re: [Qemu-devel] [RFC][PATCH] lsi53c895a: Update dnad when skipping MSGOUT bytes
Date: Mon, 10 Jan 2011 10:59:45 +0000

On Sun, Jan 9, 2011 at 11:19 PM, Nicholas A. Bellinger
<address@hidden> wrote:
> It's also worth mentioning that the sym53c8xx driver still works without
> this patch, which may be attributed to the Win2003 driver perhaps
> either:
>
> *) Sending contiguous 'Extended Messages' instead of individual messages
> (as sym53c8xx_2 appears to do) to cause the sanity check in
> lsi_add_msg_byte() and trigger the BUG
>
> *) Sending a different/wrong sized MSG out or Extended message length
> for SDTR / WDTR negoitation messages
>
> In any event, I think your change looks good and thanks for tracking
> this one down.  Please add my:
>
> Reviewed-by: Nicholas A. Bellinger <address@hidden>

Thanks for the review, I'll resend as [PATCH] and will try to find a
Windows 2003 Server guest for testing.

Stefan



reply via email to

[Prev in Thread] Current Thread [Next in Thread]