[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 0/5] usb-ccid (v14)
From: |
Alon Levy |
Subject: |
Re: [Qemu-devel] [PATCH 0/5] usb-ccid (v14) |
Date: |
Mon, 10 Jan 2011 16:32:36 +0200 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
On Mon, Jan 10, 2011 at 01:44:32PM +0100, Gerd Hoffmann wrote:
> On 01/08/11 11:28, Alon Levy wrote:
> >This patchset adds three new devices, usb-ccid, ccid-card-passthru and
> >ccid-card-emulated, providing a CCID bus, a simple passthru protocol
> >implementing card requiring a client, and a standalone emulated card.
> >
> >It also introduces a new directory libcaccard with CAC card emulation,
> >CAC is a type of ISO 7816 smart card.
> >
> >Tree for pull: git://anongit.freedesktop.org/~alon/qemu usb_ccid.v14
>
> One nit left which I didn't notice on previous reviews: It can't be
> disabled at compile time, there is no --disable-smartcard switch.
> The nss detection needs some tweaks too. The usual configure
> behavior in qemu is this:
>
> [ no smarccard option specified ]
> autodetect, i.e. enable smartcard if nss support is found,
> otherwise disable (i.e. what your patch does now).
> --disable-smartcard
> turn off smartcard support.
> --enable-smartcard
> force smartcard support on, if nss isn't present abort
> configure with an error message.
>
> Otherwise it looks works nicely. Good job.
Blue Swirl asked me to remove them at v8, so v9+ don't have them. Blue Swirl -
with or without?
>
> cheers,
> Gerd
- [Qemu-devel] [PATCH 0/5] usb-ccid (v14), Alon Levy, 2011/01/08
- [Qemu-devel] [PATCH 1/5] usb-ccid: add CCID bus, Alon Levy, 2011/01/08
- [Qemu-devel] [PATCH 2/5] ccid: add passthru card device, Alon Levy, 2011/01/08
- [Qemu-devel] [PATCH 5/5] ccid: add docs, Alon Levy, 2011/01/08
- [Qemu-devel] [PATCH 4/5] ccid: add ccid-card-emulated device (v2), Alon Levy, 2011/01/08
- [Qemu-devel] [PATCH 3/5] libcacard: initial commit after coding style fixes, Alon Levy, 2011/01/08
- Re: [Qemu-devel] [PATCH 0/5] usb-ccid (v14), Gerd Hoffmann, 2011/01/10
- Re: [Qemu-devel] [PATCH 0/5] usb-ccid (v14),
Alon Levy <=