Re: [Qemu-devel] [PATCH] arm-dis: Include opcode hex when doing disassembly

[Peter Maydell]

On 10 January 2011 10:49, Aurelien Jarno <address@hidden> wrote:
> Strangely on arm host, the opcode hex is already included, as shown
> below:
>
> | OUT: [size=308]
> | 0x01001ec0:  e5974004  ldr      r4, [r7, #4]
> | 0x01001ec4:  e1a04804  lsl      r4, r4, #16
> | 0x01001ec8:  e1a04824  lsr      r4, r4, #16
> | 0x01001ecc:  e1a04404  lsl      r4, r4, #8
>
> Maybe there is just an option to enable to allow that?

It looks like that's just an ugly #ifdef in disas.c:disas():
#ifdef __arm__
        /* since data is included in the code, it is better to
           display code data too */
        fprintf(out, "%08x  ", (int)bfd_getl32((const bfd_byte *)pc));
#endif

...so I guess if we commit the patch I submitted we should
just delete that #ifdef.

-- PMM